Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: retry for leader change error when GetTS (#44478) (#44856) #46616

Merged
merged 3 commits into from
Sep 4, 2023
Merged

lightning: retry for leader change error when GetTS (#44478) (#44856) #46616

merged 3 commits into from
Sep 4, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Sep 4, 2023 •
edited
Loading

manually cherry-pick #45330

What problem does this PR solve?

Issue Number: close #46540

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
port
7efa034 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 4, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 4, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Sep 4, 2023
@tiprow
Copy link

tiprow bot commented Sep 4, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
fix lint
f36f621 
Signed-off-by: lance6716 <[email protected]>
@lance6716
fix gosum
661b5de 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Sep 4, 2023

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@df1106e). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #46616   +/-   ##
================================================
  Coverage               ?   73.6532%           
================================================
  Files                  ?       1084           
  Lines                  ?     348176           
  Branches               ?          0           
================================================
  Hits                   ?     256443           
  Misses                 ?      75264           
  Partials               ?      16469

Benjamin2037
Benjamin2037 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-04 08:01:38.373680691 +0000 UTC m=+2346062.922696672: ☑️ agreed by Benjamin2037.
  • 2023-09-04 08:08:42.030226094 +0000 UTC m=+2346486.579242066: ☑️ agreed by lichunzhu.

@ti-chi-bot ti-chi-bot bot merged commit e2ba276 into pingcap:release-6.5 Sep 4, 2023
12 checks passed
@lance6716 lance6716 mentioned this pull request Sep 11, 2023
Closed
12 tasks
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@Tema @lance6716
lightning: retry for leader change error when GetTS (pingcap#44478) (p…
6e5334d 
…ingcap#44856) (pingcap#46616) (pingcap#1)

close pingcap#46540

Co-authored-by: lance6716 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @Benjamin2037 @lichunzhu @ti-chi-bot